Repository navigation
Feature A — Verify test-report archives for rejected merge groups (#307 merge-flow) - #1246
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a4360b071
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Feature A · Native work board
Ports the test-report provenance portion of #307 merge-flow → board landing under #1214 and #1017. T2.
An owner can opt in with a private queue-report policy. The existing Board Reader verifies the recorded failed required check IDs against the exact merge-group workflow attempt. It verifies the configured report producers and checks the downloaded SHA-256 digests before appending the archive IDs to the owner journal. Shared reports are fetched once per attempt, with the existing response budget applied to the sample.
This slice records verified archive provenance. Reading failed test names and projecting the author notice follow in the next slice. Landing shadow remains read only with respect to GitHub.
The real CLI fixture checks two failed required checks sharing an archive, a digest mismatch, and an unrelated required check. Selector controls cover mismatched attempts, producer timing, duplicate artifacts, and incomplete listings. The real #607 merge-group run supplied the two-check shared-attempt case, and both published report digests were independently verified. Formatting, whitespace checks, and isolated compilation of oxa-work tests and the work_shadow CLI test passed locally. Both hosted architecture lanes passed. Required shard 2 failed only the sandbox scratch fixture, which timed out in cargo build at 30.026 seconds. The checkout already contains #1201. Required CI recovery and independent review remain pending.
Removes: nothing.
Native shadow sample at the exact head
The x86_64 binary from checksum-matched archive
14381924695completed an isolated read-only sample at1a4360b0. The owner journal contains one sample with 57 board entries and verified archive evidence for #496, #538, and #607. For #607, it recorded exact groupace309aea04e2ab94be827a2fa89324326ba2841, run43815430013attempt 1, both failed required check IDs, and both independently verified archive IDs and digests. #794 retained its failed required checks without a verified archive entry. The journal SHA-256 wascca3f8cde47820d413897b11b443149fe16ef762ec6c2e93412fc913fc8cc232. The CLI control passed on both hosted architectures. The required-CI scratch-fixture hold remains recorded above.Reader conflict resolution
Head
40790887resolves the real conflict with #1206. The existing Reader shares one captured-byte budget and deadline across GraphQL, Actions metadata, and downloads. The CLI control covers that a REST reply which fits by itself can exceed the remaining board-snapshot budget, and that no journal record is appended in that case. Formatting, whitespace checks, and isolated compilation passed. Normal CI ran on the refreshed head. The shadow and scratch results above qualify1a4360b0only.On refreshed head
40790887, the hosted lane passed on both architectures, including the report and shared-budget control. Required shard 1 passed the same control. Its only failure wasoxa-parity::keys_settings::key_018, which timed out opening/treeafter the UI reported that the session was still busy. Shard 2 passed. Current main contains no verified fix for this failure. Exact-head required CI remains pending recovery.A fresh isolated read-only sample from checksum-matched artifact
14384586834at40790887completed with the shared Reader limits in effect. The owner journal contains one sample with 55 board entries and archive proofs for #496, #538, and #607. The #607 proof contains the same exact group, two required check IDs, run attempt, and both archive digests as the independent expected values above. #794 retained its raw rejection evidence. Journal SHA-2564a5d9e2830e285e6d7a886db2e4474b3fe15fc4ef5f876a9cba379d985a25438. This qualifies the read-only report capture on the refreshed head. The required parity-test hold remains open.Shared merge-group report verification
Head
117b10bbaddresses the review finding. The before-fix lane reproduced two downloads for a report shared by two removed PRs. The regression was the only failure in both 1,503-test jobs. The Reader now shares workflow metadata and checksum verification per attempt within a sample. Each removal still validates its own failed check IDs, group SHA, and timestamps. The extended control also covers an earlier second removal that must receive no proof from the shared cache. Formatting, whitespace checks, and isolated compilation passed. The fixed-head results follow.Required CI on
117b10bbpassed both mandatory-bwrap partitions and the gate. The exact shared-archive regression passed on x86_64 and ARM64 in the hosted lane. The verified finding thread was resolved on this head. The authenticated summary still points to the earlier reviewed head, so current-head connected review remains pending.